Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the unstable test TestFixControl45132 #46849

Merged
merged 1 commit into from
Sep 11, 2023
Merged

planner: fix the unstable test TestFixControl45132 #46849

merged 1 commit into from
Sep 11, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 11, 2023 •
edited by hawkingrei
Loading

What problem does this PR solve?

Issue Number: close #46663

Problem Summary: planner: fix the unstable test TestFixControl45132

What is changed and how it works?

planner: fix the unstable test TestFixControl45132

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2023
@tiprow
Copy link

tiprow bot commented Sep 11, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 06:25:49.48340862 +0000 UTC m=+250531.407965009: ☑️ agreed by hawkingrei.
  • 2023-09-11 06:27:23.18218652 +0000 UTC m=+250625.106742916: ☑️ agreed by winoros.

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #46849 (dd180ef) into master (02ceded) will decrease coverage by 0.6143%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46849        +/-   ##
================================================
- Coverage   73.3186%   72.7044%   -0.6143%     
================================================
  Files          1323       1344        +21     
  Lines        396611     402894      +6283     
================================================
+ Hits         290790     292922      +2132     
- Misses        87290      91398      +4108     
- Partials      18531      18574        +43
Flag Coverage Δ
integration 27.7614% <ø> (?)
unit 73.3214% <ø> (+0.0027%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9717% <ø> (ø)
br 48.3004% <ø> (-4.3454%) ⬇️

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 11, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 11, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 11, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 11, 2023

/retest-required

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@purelind
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@purelind
Copy link
Contributor

Wait for this PR #46712 to be merged first.

@purelind
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 8feabcc into pingcap:master Sep 11, 2023
15 of 16 checks passed
@wuhuizuo
Copy link
Contributor

still has flaky runs.

latest: https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/ghpr_unit_test/33129/

/reopen

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

@wuhuizuo: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to this:

still has flaky runs.

latest: https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/ghpr_unit_test/33129/

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable test TestFixControl45132
5 participants
@qw4990 @hawkingrei @purelind @wuhuizuo @winoros