Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, stats: clean the called of Index.CheckStats #46868

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Sep 11, 2023

What problem does this PR solve?

Issue Number: ref #46867

Problem Summary:

What is changed and how it works?

We will change the codes of the stats' async load since we want to reduce the persistent memory objects of statistics.

The entrance of the index's async load is very messy. This PR reduces the entrance to only one.

All other entrances will be called after the GetRowCountByIndexRanges's IsInvalid checking.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #46868 (3d3c7c7) into master (fa0c5ce) will decrease coverage by 0.0852%.
Report is 43 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46868        +/-   ##
================================================
- Coverage   73.3027%   73.2175%   -0.0852%     
================================================
  Files          1322       1349        +27     
  Lines        396235     407790     +11555     
================================================
+ Hits         290451     298574      +8123     
- Misses        87261      90757      +3496     
+ Partials      18523      18459        -64     
Flag Coverage Δ
integration 28.2245% <ø> (?)
unit 73.9182% <ø> (+0.6155%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.4168% <ø> (+0.4558%) ⬆️
br 48.8323% <ø> (-3.7859%) ⬇️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 12:57:24.641112905 +0000 UTC m=+274026.565669302: ☑️ agreed by AilinKid.
  • 2023-09-11 14:59:44.049535358 +0000 UTC m=+281365.974091748: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

2 similar comments
@winoros
Copy link
Member Author

winoros commented Sep 11, 2023

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit b7cada2 into pingcap:master Sep 12, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants