Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove useless todo comment and fix some typos for index merge #46934

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Sep 13, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: remove useless todo comment and fix some typos for index merge

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2023
@tiprow
Copy link

tiprow bot commented Sep 13, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Sep 13, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #46934 (3219fc8) into master (dc99d14) will decrease coverage by 0.6801%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46934        +/-   ##
================================================
- Coverage   73.3549%   72.6748%   -0.6801%     
================================================
  Files          1328       1352        +24     
  Lines        397004     403654      +6650     
================================================
+ Hits         291222     293355      +2133     
- Misses        87190      91663      +4473     
- Partials      18592      18636        +44     
Flag Coverage Δ
integration 27.8065% <ø> (?)
unit 73.2917% <ø> (-0.0632%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9911% <ø> (-0.0108%) ⬇️
br 48.5539% <ø> (-4.3536%) ⬇️

@AilinKid
Copy link
Contributor Author

/approve

@AilinKid
Copy link
Contributor Author

/LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

@AilinKid: you cannot LGTM your own PR.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 05:04:55.587034703 +0000 UTC m=+61861.554622745: ☑️ agreed by hawkingrei.
  • 2023-09-13 06:36:37.415882547 +0000 UTC m=+67363.383470582: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit c7f5781 into pingcap:master Sep 13, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants