-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: stop s3 retryer when connection is refused #46938
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46938 +/- ##
================================================
- Coverage 73.2870% 72.7070% -0.5801%
================================================
Files 1331 1352 +21
Lines 397358 403782 +6424
================================================
+ Hits 291212 293578 +2366
- Misses 87541 91578 +4037
- Partials 18605 18626 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lichunzhu, wjhuang2016, YuJuncen, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary:
set @@global.tidb_cloud_storage_uri
blocks when the connection is refused.What is changed and how it works?
retryerWithLog
.Check List
Tests
Before this PR, it keeps blocking if the connection is refused.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.