Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: stop s3 retryer when connection is refused #46938

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Sep 13, 2023

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

set @@global.tidb_cloud_storage_uri blocks when the connection is refused.

What is changed and how it works?

  • Refine retryerWithLog.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this PR, it keeps blocking if the connection is refused.
    mysql> set @@global.tidb_cloud_storage_uri = "s3://globalsort/addindex?access-key=minioadmin&secret-access-key=minioadmin&endpoint=http://127.0.0.1:9000&force-path-style=true";
    ERROR 1105 (HY000): RequestError: send request failed
    caused by: dial tcp 127.0.0.1:9000: connect: connection refused
    
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2023
@tiprow
Copy link

tiprow bot commented Sep 13, 2023

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta tangenta changed the title Disttask ctx cancel ddl: fix unexpected context canceled issue Sep 13, 2023
@tangenta tangenta changed the title ddl: fix unexpected context canceled issue ddl: fix unexpected context canceled error during adding index Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 06:28:07.777171427 +0000 UTC m=+66853.744759477: ☑️ agreed by ywqzzy.
  • 2023-09-13 06:30:03.743188621 +0000 UTC m=+66969.710776656: ☑️ agreed by wjhuang2016.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #46938 (238d30d) into master (c7f5781) will decrease coverage by 0.5801%.
Report is 5 commits behind head on master.
The diff coverage is 40.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46938        +/-   ##
================================================
- Coverage   73.2870%   72.7070%   -0.5801%     
================================================
  Files          1331       1352        +21     
  Lines        397358     403782      +6424     
================================================
+ Hits         291212     293578      +2366     
- Misses        87541      91578      +4037     
- Partials      18605      18626        +21     
Flag Coverage Δ
integration 27.8151% <0.0000%> (?)
unit 73.3262% <40.0000%> (+0.0392%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0019% <ø> (ø)
br 48.5973% <40.0000%> (-4.3163%) ⬇️

@tangenta
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2023
@tangenta
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, wjhuang2016, YuJuncen, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YuJuncen,lichunzhu,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tangenta tangenta changed the title ddl: fix unexpected context canceled error during adding index br: stop s3 retryer when connection is refused Sep 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit a7e3176 into pingcap:master Sep 13, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants