session/variable: forbid changing @@global.require_secure_transport to 'on' with SEM enabled #47677

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #47665

Problem Summary:

The configuration for TiDB Cloud dedicated cluster is:

require_secure_transport: OFF
ssl_ca : /var/lib/tidb-server-tls/ca.crt
ssl_cert : /var/lib/tidb-server-tls/tls.crt
ssl_key: /var/lib/tidb-server-tls/tls.key

We just provide the ca.crt file for the the users to connect the TiDB cluster. When require_secure_transport = OFF, there is no problem.

But if the user set the value of require_secure_transport to 'ON', the users can not connect to the cluster anymore!

This is because the new configuration require the mysql client to pass all ca.crt tls.crt tls.key correctly, while the user only have the ca.crt file.

What is changed and how it works?

To prevent the user from losing access of the cluster, we can forbid changing require_secure_transport system variable to 'on' as a workaround, then the user can not modify it and trigger the issue.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Modify the config.toml.example:

# Security Enhanced Mode (SEM) restricts the "SUPER" privilege and requires fine-grained privileges instead.
enable-sem = true

./bin/tidb-server -config ./pkg/config/config.toml.example
mysql -h 127.0.0.1 -u root -P 4000

mysql> set @@global.require_secure_transport = on;
ERROR 1105 (HY000): require_secure_transport can not be set to ON with SEM(security enhanced mode) enabled

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Forbid changing @@global.require_secure_transport variable to 'on' when SEM(security enhanced mode) is enabled

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiancaiamao]

/test unit-test

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bb7133]

LGTM

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@359aea8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.1     #47689   +/-   ##
================================================
  Coverage               ?   73.4788%           
================================================
  Files                  ?       1206           
  Lines                  ?     377642           
  Branches               ?          0           
================================================
  Hits                   ?     277487           
  Misses                 ?      82480           
  Partials               ?      17675           

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, CbcWestwolf, djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CbcWestwolf,bb7133,djshow832]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, CbcWestwolf, djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CbcWestwolf,bb7133,djshow832]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-10-17 07:48:48.215716515 +0000 UTC m=+1729725.802826658: ☑️ agreed by bb7133.
• 2023-10-17 10:40:25.915639607 +0000 UTC m=+1740023.502749750: ☑️ agreed by djshow832.
• 2023-10-17 10:40:31.790838755 +0000 UTC m=+1740029.377948901: ☑️ agreed by CbcWestwolf.

[Ivy-YinSu]

/test unit-test

[tiprow]

@Ivy-YinSu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.