Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix select for update statement can't get stmt-count-limit error (#48412) #48469

Merged
merged 16 commits into from
Nov 10, 2023
Merged

session: fix select for update statement can't get stmt-count-limit error (#48412) #48469

merged 16 commits into from
Nov 10, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48412

What problem does this PR solve?

Issue Number: close #48411

Problem Summary: fix select for update statement can't got stmt-count-limit error

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix issue of select for update statement can't get stmt-count-limit error

@crazycs520 @ti-chi-bot
session: fix select for update statement can't got stmt-count-limit e…
3cc1557 
…rror

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
make bazel_prepare
24c46d9 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
fix lint
245f282 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refactor code and add test
db34efa 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
add comment
7c4f8a4 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
update comment
5804cea 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
remove canReuseTxnWhenExplicitBegin since it is always false
4f1ef35 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
Revert "remove canReuseTxnWhenExplicitBegin since it is always false"
8a6f9c9 
This reverts commit 756727d.
@crazycs520 @ti-chi-bot
always call GetHistory
ae809a4 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
always call checkStmtLimit
14a8430 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
remove comment
39976d1 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refactor
1e45025 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refine comment
32c9305 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refine and add comment
2153317 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refine comment
fe17c58 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 @ti-chi-bot
refine comment
6ed9d59 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 10, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 09:01:09.626548687 +0000 UTC m=+3721267.213658832: ☑️ agreed by crazycs520.
  • 2023-11-10 03:11:54.721958566 +0000 UTC m=+3786712.309068711: ☑️ agreed by ekexium.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 10, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,ekexium,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crazycs520
Copy link
Contributor

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 4bddd59 into pingcap:release-7.5 Nov 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@ekexium ekexium ekexium approved these changes

Assignees

@crazycs520 crazycs520

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @crazycs520 @tiancaiamao @ekexium