ddl, util: Add highlight to log #4861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Oct 23, 2017
| @@ -110,9 +110,30 @@ func stringToLogLevel(level string) log.Level { | |||
| return defaultLogLevel | |||
| } | |||
|
|
|||
| // logTypeToColor converts the Level to a color string. | |||
| func logTypeToColor(level log.Level) string { | |||
There was a problem hiding this comment.
How about change this to func logTypeToColor(type string, level log.Level) string
If type is not "highlight", return "\033".
There was a problem hiding this comment.
Only highlight need to call this function and write color code.
There was a problem hiding this comment.
So why not call it logLevelToColor?
|
LGTM |
shenli
reviewed
Oct 23, 2017
util/logutil/log.go
Outdated
| @@ -123,6 +144,12 @@ func (f *textFormatter) Format(entry *log.Entry) ([]byte, error) { | |||
| } else { | |||
| b = &bytes.Buffer{} | |||
| } | |||
|
|
|||
| if !f.DisableColors { | |||
There was a problem hiding this comment.
Rename DisableColors to EnableColors. It will be more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only add highlight log to highlight type.
logrusdefault color only supports "[loglevel]" and "file=xxx.go" fields to have colors.I think using
highlightto debug more easily. In order not to affect everyone's use, I add a new type.