Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: make sure fsr credit is full filled (#48627) #48742

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48627

What problem does this PR solve?

Issue Number: close #48629

Problem Summary:

What is changed and how it works?

Make sure ebs snapshot fsr credit is enough before creating volumes against them. IAM privilege of cloudwatch:GetMetricStatistics is required.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 21, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 21, 2023
Copy link

ti-chi-bot bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2023
Copy link

ti-chi-bot bot commented Nov 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-21 10:21:32.760841286 +0000 UTC m=+313321.426067502: ☑️ agreed by BornChanger.
  • 2023-11-21 10:22:43.42419297 +0000 UTC m=+313392.089419165: ☑️ agreed by 3pointer.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@7292ec6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48742   +/-   ##
================================================
  Coverage               ?   73.6406%           
================================================
  Files                  ?       1085           
  Lines                  ?     349018           
  Branches               ?          0           
================================================
  Hits                   ?     257019           
  Misses                 ?      75519           
  Partials               ?      16480           

@ti-chi-bot ti-chi-bot bot merged commit 981e19a into pingcap:release-6.5 Nov 21, 2023
19 checks passed
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
…48742) (pingcap#27)

close pingcap#48629

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants