server,executor: split ResultSet Close() to Finish() and Close() (#49224)

[ti-chi-bot]

This is an automated cherry-pick of #49224

What problem does this PR solve?

Issue Number: close #48667

Problem Summary:

What changed and how does it work?

In the old interface design, ResultSet.Close() may return error, and we must make sure the error is returned to the client, otherwise we get this issue #48446

In the previous #48447 I make sure the error is returned, but that cause peformance regression #48667

So the idea is split the work of Close() into two: the part that may return error and the part that may not return error.

	Finish() error
	Close()

We call Finish() first and writeEOF(), then call Close().

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Run sysbench and get the flamegraph:

Now Close() will be after writeChunks() and there is a Finish() call inside writeChunks().

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign winkyao for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/unit-test	ccf0607	link	true	/test unit-test
idc-jenkins-ci-tidb/check_dev_2	ccf0607	link	true	/test check-dev2
idc-jenkins-ci-tidb/check_dev	ccf0607	link	true	/test check-dev
idc-jenkins-ci-tidb/mysql-test	ccf0607	link	true	/test mysql-test
idc-jenkins-ci-tidb/build	ccf0607	link	true	/test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.