Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: fix goleak for syscall #50142

Merged
merged 1 commit into from
Jan 5, 2024
Merged

store: fix goleak for syscall #50142

merged 1 commit into from
Jan 5, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 5, 2024

What problem does this PR solve?

Issue Number: close #50141

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #50142 (c846e3b) into master (c334685) will increase coverage by 2.6914%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50142        +/-   ##
================================================
+ Coverage   79.3138%   82.0053%   +2.6914%     
================================================
  Files          2445       2447         +2     
  Lines        673615     674350       +735     
================================================
+ Hits         534270     553003     +18733     
+ Misses       117962     100593     -17369     
+ Partials      21383      20754       -629     
Flag Coverage Δ
integration 48.9022% <ø> (?)
unit 79.3446% <100.0000%> (+0.0307%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (ø)
parser ∅ <ø> (∅)
br 71.8855% <ø> (+3.3882%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 11:52:14.690671372 +0000 UTC m=+12124.274925055: ☑️ agreed by lance6716.
  • 2024-01-05 13:02:58.685581096 +0000 UTC m=+16368.269834781: ☑️ agreed by GMHDBJD.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jan 5, 2024

/retest

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jan 5, 2024

/check-issue-triage-complete

1 similar comment
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

Copy link

tiprow bot commented Jan 5, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test c846e3b link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 6bff4aa into pingcap:master Jan 5, 2024
19 of 20 checks passed
@hawkingrei hawkingrei deleted the 50141 branch January 5, 2024 14:02
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goleak in the syscall.Syscall
3 participants