Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: make TestUpgradeVersionForResumeJob faster #50299

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jan 11, 2024

What problem does this PR solve?

Issue Number: close #50292

Problem Summary:
The two "add index" jobIDs are not necessarily serial in OnGetJobBeforeExported after #48728.

What changed and how does it work?

Remove the duplicated check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2024
Copy link

tiprow bot commented Jan 11, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Merging #50299 (af8ddd6) into master (4252974) will decrease coverage by 16.2515%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50299         +/-   ##
=================================================
- Coverage   71.8495%   55.5981%   -16.2515%     
=================================================
  Files          1443       1555        +112     
  Lines        346893     587813     +240920     
=================================================
+ Hits         249241     326813      +77572     
- Misses        77327     238312     +160985     
- Partials      20325      22688       +2363     
Flag Coverage Δ
integration 36.8366% <ø> (?)
unit 70.2060% <ø> (-1.6436%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.2860%) ⬇️
parser ∅ <ø> (∅)
br 55.6081% <ø> (+4.2719%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 03:34:50.636917214 +0000 UTC m=+500680.221170900: ☑️ agreed by tangenta.
  • 2024-01-11 03:42:50.889790505 +0000 UTC m=+501160.474044192: ☑️ agreed by Defined2014.

@Defined2014
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Jan 11, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 11, 2024

@zimulala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test af8ddd6 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 2fdc3a3 into pingcap:master Jan 11, 2024
21 of 22 checks passed
@zimulala zimulala deleted the zimuxia/speedup-test branch February 23, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/test lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestUpgradeVersionForResumeJob execution timeout
3 participants