-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs_br: allow temporary TiKV unreachable during starting snapshot backup (#49154) #50443
ebs_br: allow temporary TiKV unreachable during starting snapshot backup (#49154) #50443
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yu Juncen <yu745514916@live.com>
…erry-pick-49154-to-release-7.5 Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
/retest |
/retest |
Signed-off-by: Yu Juncen <yu745514916@live.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #50443 +/- ##
================================================
Coverage ? 71.9665%
================================================
Files ? 1407
Lines ? 408594
Branches ? 0
================================================
Hits ? 294051
Misses ? 94763
Partials ? 19780
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
/retest-required |
This is an automated cherry-pick of #49154, #50316, #48439
What problem does this PR solve?
Issue Number: close #49152, close #49153
Problem Summary:
See the issue.
For #49152, we didn't add retry for starting suspending lightning.
For #49153, we just break the loop when keeper encounters errors, this may cause the final consistency check passes because of the request of extend lease.
What changed and how does it work?
Fixed the problems above by retry and fail fast.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.