Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky case #50525

Merged
merged 1 commit into from
Jan 18, 2024
Merged

test: fix flaky case #50525

merged 1 commit into from
Jan 18, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50524

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test, just increase wait time
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2024
Copy link

tiprow bot commented Jan 17, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/check-issue-triage-complete

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Merging #50525 (011ec26) into master (bbbada0) will decrease coverage by 14.5441%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50525         +/-   ##
=================================================
- Coverage   70.2283%   55.6843%   -14.5441%     
=================================================
  Files          1452       1563        +111     
  Lines        420088     588803     +168715     
=================================================
+ Hits         295021     327871      +32850     
- Misses       104762     238201     +133439     
- Partials      20305      22731       +2426     
Flag Coverage Δ
integration 36.9874% <ø> (?)
unit 70.2961% <ø> (+0.0677%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 57.0059% <ø> (+6.5840%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 02:02:24.380642401 +0000 UTC m=+407785.944940106: ☑️ agreed by lance6716.
  • 2024-01-18 02:26:55.736659897 +0000 UTC m=+409257.300957586: ☑️ agreed by okJiang.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 549a5d9 into pingcap:master Jan 18, 2024
19 of 20 checks passed
@D3Hunter D3Hunter deleted the fix50524 branch January 18, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestFrameworkScaleInAndOut
3 participants