Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: split cursor test #50683

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 24, 2024

What problem does this PR solve?

Issue Number: close #50682

Problem Summary:

What changed and how does it work?

Actually, there are many test issues in TiDB, but because there are sequence-related problems before the tests, and in the original tests, the tests are too many and the capacity of shard_count has been consumed. Therefore, we have to split a new package to avoid conflicts between tests. At the same time, this approach can also make use of cache to speed up.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Jan 24, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2024
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,YangKeao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 04:32:34.454893294 +0000 UTC m=+935196.019190994: ☑️ agreed by YangKeao.
  • 2024-01-24 04:36:02.672366656 +0000 UTC m=+935404.236664358: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #50683 (82226a1) into master (8e5d98d) will decrease coverage by 14.6981%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50683         +/-   ##
=================================================
- Coverage   70.3551%   55.6570%   -14.6981%     
=================================================
  Files          1456       1567        +111     
  Lines        420737     588448     +167711     
=================================================
+ Hits         296010     327513      +31503     
- Misses       104400     238146     +133746     
- Partials      20327      22789       +2462     
Flag Coverage Δ
integration 36.7637% <ø> (?)
unit 70.2618% <ø> (-0.0816%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.6008% <ø> (+6.0699%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit c936265 into pingcap:master Jan 24, 2024
23 checks passed
@hawkingrei hawkingrei deleted the fix_server_test branch January 24, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestCursorFetchErrorInFetch
3 participants