-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove goCtx from session struct #5174
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ea52d66
*: remove goCtx from session
tiancaiamao 79a06b3
address comment
tiancaiamao fc2729d
make golint happy
tiancaiamao f0a496e
address comment
tiancaiamao b307766
Merge branch 'master' into remove-session-ctx
tiancaiamao a663fb1
Merge branch 'master' into remove-session-ctx
tiancaiamao ce1eea6
Merge branch 'master' into remove-session-ctx
zz-jason 6fd7f02
Merge branch 'master' into remove-session-ctx
winoros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ import ( | |
"github.com/pingcap/tidb/types" | ||
"github.com/pingcap/tidb/util/chunk" | ||
"github.com/pingcap/tidb/util/logutil" | ||
goctx "golang.org/x/net/context" | ||
) | ||
|
||
type processinfoSetter interface { | ||
|
@@ -167,7 +168,7 @@ func (a *ExecStmt) IsReadOnly() bool { | |
// This function builds an Executor from a plan. If the Executor doesn't return result, | ||
// like the INSERT, UPDATE statements, it executes in this function, if the Executor returns | ||
// result, execution is done after this function returns, in the returned ast.RecordSet Next method. | ||
func (a *ExecStmt) Exec(ctx context.Context) (ast.RecordSet, error) { | ||
func (a *ExecStmt) Exec(goCtx goctx.Context, ctx context.Context) (ast.RecordSet, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The second |
||
a.startTime = time.Now() | ||
a.ctx = ctx | ||
|
||
|
@@ -193,7 +194,7 @@ func (a *ExecStmt) Exec(ctx context.Context) (ast.RecordSet, error) { | |
return nil, errors.Trace(err) | ||
} | ||
|
||
if err := e.Open(); err != nil { | ||
if err := e.Open(goCtx); err != nil { | ||
return nil, errors.Trace(err) | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,19 +21,18 @@ import ( | |
"github.com/pingcap/tidb/context" | ||
"github.com/pingcap/tidb/infoschema" | ||
"github.com/pingcap/tidb/plan" | ||
goctx "golang.org/x/net/context" | ||
) | ||
|
||
// Compiler compiles an ast.StmtNode to a physical plan. | ||
type Compiler struct { | ||
} | ||
|
||
// Compile compiles an ast.StmtNode to a physical plan. | ||
func (c *Compiler) Compile(ctx context.Context, stmtNode ast.StmtNode) (*ExecStmt, error) { | ||
if ctx.GoCtx() != nil { | ||
if span := opentracing.SpanFromContext(ctx.GoCtx()); span != nil { | ||
span1 := opentracing.StartSpan("executor.Compile", opentracing.ChildOf(span.Context())) | ||
defer span1.Finish() | ||
} | ||
func (c *Compiler) Compile(goCtx goctx.Context, ctx context.Context, stmtNode ast.StmtNode) (*ExecStmt, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove the second |
||
if span := opentracing.SpanFromContext(goCtx); span != nil { | ||
span1 := opentracing.StartSpan("executor.Compile", opentracing.ChildOf(span.Context())) | ||
defer span1.Finish() | ||
} | ||
|
||
infoSchema := GetInfoSchema(ctx) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we don't need the second
context.Context
.The
Statement
has one in its struct.