Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: simplify logic #5185

Merged
merged 4 commits into from
Nov 22, 2017
Merged

executor: simplify logic #5185

merged 4 commits into from
Nov 22, 2017

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 22, 2017 •
edited
Loading

Fix #5181

@shenli shenli mentioned this pull request Nov 22, 2017
Merged
@hicqu
Copy link
Contributor Author

hicqu commented Nov 22, 2017

/run-all-tests

@winoros winoros changed the title *: Fix #5181 and #5179. executor: simplify logic Nov 22, 2017
winoros
winoros reviewed Nov 22, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2017
ngaut
ngaut approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 0ff13ce into pingcap:master Nov 22, 2017
@hicqu hicqu deleted the fix-redundant branch November 22, 2017 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@ngaut ngaut ngaut approved these changes

@zimulala zimulala Awaiting requested review from zimulala

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hicqu @ngaut @winoros