Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: change executor Next() interface to Next(goctx.Context) #5223

Merged
merged 2 commits into from
Nov 27, 2017
Merged

*: change executor Next() interface to Next(goctx.Context) #5223

merged 2 commits into from
Nov 27, 2017

Conversation

tiancaiamao
Copy link
Contributor

It's a further step after we remove goCtx from session struct
This refactor makes the code confirm to Go convention.

@coocood

@coocood
Copy link
Member

coocood commented Nov 26, 2017

LGTM

@shenli
Copy link
Member

shenli commented Nov 26, 2017

/run-all-tests

@shenli
Copy link
Member

shenli commented Nov 27, 2017

Please fix CI.

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

It's affected by the CI environment. @shenli

shenli
shenli approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit fb610e6 into pingcap:master Nov 27, 2017
@tiancaiamao tiancaiamao deleted the refact-next branch November 27, 2017 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @coocood @shenli