importinto: fix panic when import to a temporary table, disallow import to cached table #55983
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
D3Hunter
changed the title
D3Hunter
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55983 +/- ##
=================================================
- Coverage 72.8566% 57.1267% -15.7299%
=================================================
Files 1605 1737 +132
Lines 446334 632838 +186504
=================================================
+ Hits 325184 361520 +36336
- Misses 101114 247780 +146666
- Partials 20036 23538 +3502
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/planner/core/planbuilder.go
Outdated
| @@ -4389,6 +4389,10 @@ func (b *PlanBuilder) buildImportInto(ctx context.Context, ld *ast.ImportIntoStm | |||
| } | |||
|
|
|||
| tnW := b.resolveCtx.GetTableName(ld.Table) | |||
| if tnW.TableInfo.TempTableType != model.TempTableNone || | |||
| tnW.TableInfo.TableCacheStatusType != model.TableCacheStatusDisable { | |||
| return nil, errors.Errorf("IMPORT INTO does not support temporary table or cached table") | |||
There was a problem hiding this comment.
Could you separate this message into "IMPORT INTO does not support temporary table" and "IMPORT INTO does not support cached table"? It is more clear and easy to extend to more checks if needed in the future
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
| @@ -4389,6 +4389,11 @@ func (b *PlanBuilder) buildImportInto(ctx context.Context, ld *ast.ImportIntoStm | |||
| } | |||
|
|
|||
| tnW := b.resolveCtx.GetTableName(ld.Table) | |||
| if tnW.TableInfo.TempTableType != model.TempTableNone { | |||
| return nil, errors.Errorf("IMPORT INTO does not support temporary table") | |||
| } else if tnW.TableInfo.TableCacheStatusType != model.TableCacheStatusDisable { | |||
There was a problem hiding this comment.
| } else if tnW.TableInfo.TableCacheStatusType != model.TableCacheStatusDisable { | |
| } | |
| if tnW.TableInfo.TableCacheStatusType != model.TableCacheStatusDisable { |
|
/assign @fixdb |
|
/assign @winoros |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, hawkingrei, lance6716, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55970
Problem Summary:
What changed and how does it work?
add a check in plan build
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.