ddl: fix panic in TablePartitionArgs v2

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

introduced in #56163, we need to make sure that PartInfo is not nil for DropPartition and roll-backing AddPartition, for v1 we have make sure it already, but forget v2

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

run TestAddPartitionReplicaBiggerThanTiFlashStores with v1/v2, make sure it pass

run TestTiFlashReorgPartition with v2, pass

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[joccau]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.0552%. Comparing base (d55808c) to head (2d475de).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56222        +/-   ##
================================================
+ Coverage   73.4698%   76.0552%   +2.5854%     
================================================
  Files          1600       1622        +22     
  Lines        443771     451749      +7978     
================================================
+ Hits         326038     343579     +17541     
+ Misses        97754      86797     -10957     
- Partials      19979      21373      +1394     

Flag	Coverage Δ
integration	52.2367% <62.5000%> (?)
unit	72.4883% <62.5000%> (-0.0469%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (-0.0089%)	⬇️
parser	∅ <ø> (∅)
br	63.0923% <ø> (+17.2296%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-23 07:32:11.770891256 +0000 UTC m=+1464801.511315195: ☑️ agreed by joccau.
• 2024-09-23 07:39:13.819842834 +0000 UTC m=+1465223.560266787: ☑️ agreed by lance6716.

[D3Hunter]

/hold

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joccau, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [lance6716]
• pkg/meta/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[D3Hunter]

/unhold