-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix foreign key consistency under async commit #56349
Conversation
#48524 Fixed more bugs. It's prefered to merge that one. |
Please go ahead on it because other bugs are not verifed yet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56349 +/- ##
================================================
+ Coverage 73.3685% 76.0142% +2.6456%
================================================
Files 1624 1646 +22
Lines 448117 456833 +8716
================================================
+ Hits 328777 347258 +18481
+ Misses 99198 87948 -11250
- Partials 20142 21627 +1485
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… commit Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiyfhust, mjonss, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #48297
ref #23363
Problem Summary:
The foreign key consistency may be broken when an async commit DML is running concurrently with "add foreign key` DDL.
What changed and how does it work?
Add
delayForAsyncCommit()
before checking the foreign key.Check List
Tests
Release note