do gc parallel #5832
do gc parallel #5832
Conversation
|
Any test? |
| err error | ||
| } | ||
|
|
||
| func getNextGCTask(store tikv.Storage, bo *tikv.Backoffer, safePoint uint64, lastKey kv.Key) (*gcTask, error) { |
There was a problem hiding this comment.
s/getNextGCTask/genNextGCTask
|
|
||
| log.Infof("[gc worker] %s start gc, safePoint: %v.", identifier, safePoint) | ||
| startTime := time.Now() | ||
| func doGCForOneRange(ctx goctx.Context, store tikv.Storage, task *gcTask, identifier string) *gcResult { |
There was a problem hiding this comment.
Seems you should use a range as the input args from the function name.
| } | ||
| } | ||
|
|
||
| func doGCTask(ctx goctx.Context, store tikv.Storage, identifier string, resChan chan *gcResult, task *gcTask) { |
There was a problem hiding this comment.
This function should wait on a task queue and handle task one by one util receive nil.
| }() | ||
|
|
||
| var key []byte | ||
| gcResultChan := make(chan *gcResult, gcDefaultGCConcurrency) |
There was a problem hiding this comment.
gcTaskQueue := make(chan gcTask, gcDefaultGCConcurrency)
gcTaskCh := make(chan gcTask, 1024)
for i = 0; i < gcDefaultGCConcurrency; i++ {
go runGcTaskWorker(gcTaskQueue, gcResultCh)
}
var key []byte
for {
task, err := genNextGCTask(...)
if err != nil {...}
if task == nil {
send N nil to gcTaskQueue, notify all workers to quit
break;
}
gcTaskQueue <- task
...receive task results if have
}
reveive task results util N nil
|
Duplicate with #5850 |
as title says