Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: run gc workers parallelly #5837

Merged
merged 15 commits into from
Feb 9, 2018
Merged

store/tikv: run gc workers parallelly #5837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9463c94
run gc workers parallelly
zhangjinpeng87 Feb 9, 2018
1945bd0
fix bug
zhangjinpeng87 Feb 9, 2018
87693c9
dynamically to change gcConcurrency
wentaoxu Feb 9, 2018
50cefba
add test and dynically change gcConcurrency
wentaoxu Feb 9, 2018
4fe2f76
fix ut
wentaoxu Feb 9, 2018
8c51b33
fix comments
wentaoxu Feb 9, 2018
9028003
Merge branch 'master' into zhangjinpeng/parallel-gc
wentaoxu Feb 9, 2018
0870b77
fix channel length
wentaoxu Feb 9, 2018
3f58cb2
remove gcResultChan
wentaoxu Feb 9, 2018
d078864
fix comments
wentaoxu Feb 9, 2018
b2dc868
fix comments
wentaoxu Feb 9, 2018
59d44aa
Merge branch 'master' into zhangjinpeng/parallel-gc
wentaoxu Feb 9, 2018
d46d475
fix comments
wentaoxu Feb 9, 2018
d8aa1b5
fix comments
wentaoxu Feb 9, 2018
f4c459d
fix comments
wentaoxu Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions cmd/benchdb/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (

"github.com/pingcap/tidb"
"github.com/pingcap/tidb/store/tikv"
"github.com/pingcap/tidb/store/tikv/gcworker"
"github.com/pingcap/tidb/terror"
"github.com/pingcap/tidb/util/logutil"
log "github.com/sirupsen/logrus"
Expand Down Expand Up @@ -79,8 +78,6 @@ func main() {
ut.updateRangeRows(spec)
case "select":
ut.selectRows(spec)
case "gc":
ut.manualGC(nil)
case "query":
ut.query(spec)
default:
Expand Down Expand Up @@ -276,24 +273,6 @@ func (ut *benchDB) selectRows(spec string) {
})
}

// manualGC manually triggers GC and sends to done channel after finished.
func (ut *benchDB) manualGC(done chan bool) {
cLog("GC started")
start := time.Now()
ver, err := ut.store.CurrentVersion()
if err != nil {
log.Fatal(err)
}
err = gcworker.RunGCJob(goctx.Background(), ut.store, ver.Ver, "benchDB")
if err != nil {
log.Fatal(err)
}
cLog("GC finished, duration ", time.Since(start))
if done != nil {
done <- true
}
}

func (ut *benchDB) query(spec string) {
strs := strings.Split(spec, ":")
sql := strs[0]
Expand Down
Loading