plan: refactor errors #6377
Merged
plan: refactor errors #6377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/go/src/github.com/pingcap/tidb/plan/errors.go:50:2: exported var ErrUnsupportedType should have comment or be unexported |
winoros
reviewed
Apr 26, 2018
executor/prepared_test.go
Outdated
| @@ -260,5 +260,5 @@ func (s *testSuite) TestPreparedNameResolver(c *C) { | |||
| tk.MustExec("create table t (id int, KEY id (id))") | |||
| tk.MustExec("prepare stmt from 'select * from t limit ? offset ?'") | |||
| _, err := tk.Exec("prepare stmt from 'select b from t'") | |||
| c.Assert(err.Error(), Equals, "[plan:1054]Unknown column 'b' in 'field list'") | |||
| c.Assert(err.Error(), Equals, "[optimizer:1054]Unknown column 'b' in 'field list'") | |||
|
/run-all-tests |
|
/run-common-test |
XuHuaiyu
reviewed
Apr 28, 2018
plan/expression_rewriter.go
Outdated
| @@ -1177,7 +1177,7 @@ func (er *expressionRewriter) funcCallToExpression(v *ast.FuncCallExpr) { | |||
| func (er *expressionRewriter) toColumn(v *ast.ColumnName) { | |||
| column, err := er.schema.FindColumn(v) | |||
| if err != nil { | |||
| er.err = ErrAmbiguous.GenByArgs(v.Name) | |||
| er.err = ErrAmbiguous.GenByArgs(v.Name, "field list") | |||
There was a problem hiding this comment.
s/ "field list"/ clauseMsg[fieldList]
so as the others.
| @@ -774,14 +774,14 @@ func (b *planBuilder) buildLimit(src LogicalPlan, limit *ast.Limit) LogicalPlan | |||
| if limit.Offset != nil { | |||
| offset, err = getUintForLimitOffset(sc, limit.Offset.GetValue()) | |||
| if err != nil { | |||
| b.err = ErrWrongArguments | |||
| b.err = ErrWrongArguments.GenByArgs("LIMIT") | |||
There was a problem hiding this comment.
add test case for this in TestNameResolver?
There was a problem hiding this comment.
the Offset and Count of ast.Limit is guaranteed to be a value of uint64 by parser, maybe we should delete this check.
There was a problem hiding this comment.
But if offset and count are paramMarker, they are not guaranteed to be uint64.
|
LGTM |
|
@winoros PTAL |
|
@zz-jason Please fix the confliction |
|
@zimulala done, PTAL |
|
/run-all-tests |
zimulala
added
status/LGT2
zz-jason
added a commit
that referenced
this pull request
Jun 7, 2018
zz-jason
added a commit
that referenced
this pull request
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors.goterror.ClassOptimizerPlan