session: support setting tso into session variable "tidb_snapshot" #6749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhexuany
requested review from
coocood and
XuHuaiyu
and removed request for
coocood
|
LGTM |
|
/run-all-tests |
shenli
reviewed
Jun 5, 2018
types/time.go
Outdated
| @@ -45,6 +45,10 @@ const ( | |||
| TimeFormat = "2006-01-02 15:04:05" | |||
| // TimeFSPFormat is time format with fractional seconds precision. | |||
| TimeFSPFormat = "2006-01-02 15:04:05.000000" | |||
|
|
|||
| // used for encodinh/decoding tso | |||
| physicalShiftBits = 18 | |||
There was a problem hiding this comment.
There is a constant in store/tikv/oracle/oracle.go. Could we use that one?
|
We need to update the related document. |
|
@shenli PTAL |
shenli
reviewed
Jun 5, 2018
sessionctx/variable/varsutil.go
Outdated
|
|
||
| if tso, err2 := strconv.ParseUint(sVal, 10, 64); err2 == nil { | ||
| s.SnapshotTS = tso | ||
| return errors.Trace(nil) |
|
@shenli PTAL |
zimulala
reviewed
Jun 5, 2018
store/tikv/oracle/oracle.go
Outdated
| @@ -48,3 +48,15 @@ func ExtractPhysical(ts uint64) int64 { | |||
| func GetPhysical(t time.Time) int64 { | |||
| return t.UnixNano() / int64(time.Millisecond) | |||
| } | |||
|
|
|||
| // EncodeTso encodes a millisecond into tso. | |||
| func EncodeTso(ts int64) uint64 { | |||
store/tikv/oracle/oracle.go
Outdated
| } | ||
|
|
||
| // DecodeTso decodes a tso into a golang's time struct. | ||
| func DecodeTso(tso uint64) time.Time { |
There was a problem hiding this comment.
Do we use this function? Could we remove it？
zimulala
reviewed
Jun 5, 2018
sessionctx/variable/varsutil.go
Outdated
| t, err := types.ParseTime(s.StmtCtx, sVal, mysql.TypeTimestamp, types.MaxFsp) | ||
|
|
sessionctx/variable/varsutil.go
Outdated
| @@ -175,10 +175,18 @@ func setSnapshotTS(s *SessionVars, sVal string) error { | |||
| s.SnapshotTS = 0 | |||
| return nil | |||
| } | |||
|
|
|||
| if tso, err2 := strconv.ParseUint(sVal, 10, 64); err2 == nil { | |||
|
@zimulala All comments are addressed. PTAL |
zhexuany
force-pushed
the
support_tso_when_use_tidb_snapshot
branch
from
7c78f53
to
e6e88d1
Compare
zimulala
reviewed
Jun 6, 2018
store/tikv/oracle/oracle.go
Outdated
| } | ||
|
|
||
| // DecodeTSO decodes a tso into a golang's time struct. | ||
| func DecodeTSO(tso uint64) time.Time { |
There was a problem hiding this comment.
Do we use this function? Could we remove it？
zimulala
added
status/LGT2
|
/run-all-tests |
zhexuany
changed the title
|
@zhexuany We need to cherry-pick this to the release-2.0 branch. |
zhexuany
added a commit
to zhexuany/tidb
that referenced
this pull request
Jun 12, 2018
This was referenced Jun 12, 2018
|
confirmed with @WangXiangUSTC, as long as this PR be in part of 2.0.4 release, they are fine with this. |
coocood
pushed a commit
that referenced
this pull request
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR,
set @@tidb_snapshot= '400036290571534337'can be used.