-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lexer: support more syntaxes regarding 'SET Syntax' #7020
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
@qazbnm456 Thanks! |
/ok-to-test |
1 similar comment
/ok-to-test |
/run-all-tests |
Is there a MySQL document link about it? @qazbnm456 |
@tiancaiamao Yup, here is the docs: https://dev.mysql.com/doc/refman/5.7/en/user-variables.html. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qazbnm456 thank you for your contribution! Please add some test cases in
Line 484 in 10151e1
func (s *testParserSuite) TestDBAStmt(c *C) { |
@JackDrogon Added! Thanks. |
Are they all equal?
How about this:
|
Yes, they're the same in MySQL. Example: http://sqlfiddle.com/#!9/9eecb/46076. |
I mean, could this PR handle the case, in TiDB |
@tiancaiamao I just updated my comment with a picture showing that the case would be handled correctly in |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What have you changed? (mandatory)
I've changed lines of the code of
lexer.go
in order to support more syntaxes regarding 'SET Syntax', which also fixes #6990.What are the type of the changes (mandatory)?
Improvement.
How has this PR been tested (mandatory)?
Manual test.
Does this PR affect documentation (docs/docs-cn) update? (optional)
No.
Refer to a related PR or issue link (optional)
#6990