Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: reduce conflict for updating column size #7124

Merged
merged 6 commits into from
Jul 24, 2018
Merged

stats: reduce conflict for updating column size #7124

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b24b062
stats: reduce conflict for updating column size
Jul 23, 2018
700d749
use `insert on duplicate update`
Jul 23, 2018
1bd81f5
use batch insert
Jul 23, 2018
b8fa195
remove useless select
Jul 23, 2018
a40a2d5
rename variables
Jul 23, 2018
91acb8f
Merge branch 'master' into colsize
alivxxx Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions statistics/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"fmt"
"math"
"strconv"
"strings"
"sync"
"time"

Expand Down Expand Up @@ -344,17 +345,16 @@ func (h *Handle) dumpTableStatColSizeToKV(id int64, delta variable.TableDelta) (
err = finishTransaction(ctx, exec, err)
}()
version := h.mu.ctx.Txn().StartTS()

for key, val := range delta.ColSize {
if val == 0 {
values := make([]string, 0, len(delta.ColSize))
for histID, deltaColSize := range delta.ColSize {
if deltaColSize == 0 {
continue
}
sql := fmt.Sprintf("update mysql.stats_histograms set version = %d, tot_col_size = tot_col_size + %d where hist_id = %d and table_id = %d and is_index = 0", version, val, key, id)
_, err = exec.Execute(ctx, sql)
if err != nil {
return
}
values = append(values, fmt.Sprintf("(%d, 0, %d, 0, %d, %d)", id, histID, deltaColSize, version))
}
sql := fmt.Sprintf("insert into mysql.stats_histograms (table_id, is_index, hist_id, distinct_count, tot_col_size, version) "+
"values %s on duplicate key update tot_col_size = tot_col_size + values(tot_col_size), version = values(version)", strings.Join(values, ","))
_, err = exec.Execute(ctx, sql)
return
}

Expand Down