variable: Change the default value of charset/collation to utfbmb4/utf8mb4_bin #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
added
type/compatibility
release-note
|
/run-all-tests |
|
Why not |
|
There is no difference between |
|
/run-unit-test |
…f8mb4_bin TiDB does not support latin charset now. So change them to utf8mb4 to avoid potential issues.
Change the default charset/collation from utf8mb4 to utf8.
|
@coocood PTAL |
coocood
approved these changes
Aug 9, 2018
|
LGTM |
|
/run-unit-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Change the default value of charset/collation to utfbmb4/utf8mb4_bin.
TiDB does not support Latin charset now. So change them to utf8mb4 to avoid potential issues.
Fix #7046
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Exists tests.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Yes
Does this PR affect tidb-ansible update? (mandatory)
No
Does this PR need to be added to the release notes? (mandatory)
Yes
Refer to a related PR or issue link (optional)
#7046
Benchmark result if necessary (optional)
No
Add a few positive/negative examples (optional)
No