Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan, executor: check b.err when building logical plan(#7114)(#7204) #7225

Merged
merged 5 commits into from
Aug 2, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Aug 1, 2018

cherry-pick #7144 #7204

@XuHuaiyu XuHuaiyu added this to the 2.0 milestone Aug 1, 2018
@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Aug 1, 2018
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Aug 1, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

winkyao
winkyao previously approved these changes Aug 1, 2018
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shenli
shenli previously approved these changes Aug 1, 2018
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu dismissed stale reviews from shenli and winkyao via 4ee2dcb August 1, 2018 09:28
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Aug 1, 2018

/run-unit-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason
Copy link
Member

zz-jason commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 2, 2018
@zz-jason zz-jason merged commit 64673ee into pingcap:release-2.0 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants