Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, ddl: get the correct result of "show create table" when running "add index" (#6993) #7243

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 2, 2018

cherry pick #6993

What have you changed? (mandatory)

Get the correct result of "show create table" when executing "add index".
Fix #6991

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

No.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@zimulala
Copy link
Contributor Author

zimulala commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zimulala zimulala added the type/bugfix This PR fixes a bug. label Aug 2, 2018
@zimulala
Copy link
Contributor Author

zimulala commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Aug 2, 2018
@coocood coocood merged commit 50fdc54 into pingcap:release-2.0 Aug 2, 2018
@zimulala zimulala deleted the show-create branch August 2, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants