expression: handle max_allowed_packet warnings for pad functions (#7171) #7244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
added
component/expression
type/2.0 cherry-pick
release-note
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
1 similar comment
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/rebuild |
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
@zimulala PTAL again |
zimulala
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
cherry pick #7171 to release 2.0
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
Does this PR need to be added to the release notes? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)