Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: init builder startTS in buildTableDual #7246

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 2, 2018

Cherry-pick #6830

What have you changed? (mandatory)

When we build an index join executor with outer table is table dual, we never call b.getStartTS during build time.
But later when we execute the query, we use the builder to build inner table which needs startTS, but by then, the transaction is set to invalid, then we panic.

This PR init the startTS in executorBuilder.buildTableDual to fix the panic issue.

What are the type of the changes (mandatory)?

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested (mandatory)?

  • unit-test

@coocood
Copy link
Member Author

coocood commented Aug 2, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Aug 2, 2018

LGTM

@coocood
Copy link
Member Author

coocood commented Aug 2, 2018

/run-mybatis-test tikv=release-2.0 tidb-test=release-2.0

@coocood coocood merged commit 491d446 into pingcap:release-2.0 Aug 2, 2018
@coocood coocood deleted the builder-start-ts-2.0 branch August 2, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants