parser: support of character in create table statement #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Aug 13, 2018
| @@ -6094,6 +6094,17 @@ StringType: | |||
| } | |||
| $$ = x | |||
| } | |||
| | "NATIONAL" "CHARACTER" FieldLen OptBinary OptCollate | |||
There was a problem hiding this comment.
Can we define a new parser rule like:
CharOrCharacter:
"CHAR" | "CHARACTER"
Then we could merge this into the first branch.
There was a problem hiding this comment.
@shenli
NationalOpt could be empty, "CHAR(10)" is legal, but "CHARACTER(10)" is illegal in MySQL. There must be a "NATIONAL" before "CHARACTER".
|
LGTM |
|
/run-all-tests |
shenli
approved these changes
Aug 13, 2018
| @@ -6094,6 +6094,17 @@ StringType: | |||
| } | |||
| $$ = x | |||
| } | |||
| | "NATIONAL" "CHARACTER" FieldLen OptBinary OptCollate | |||
shenli
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #7371 to make some JDBC test cases happy.
What is changed and how it works?
Support
NATIONAL CHARACTERtype in create table statement, likecreate table t (c1 NATIONAL CHARACTER(10));by add parser rules. BecauseNATIONAL CHARACTERis same asNATIONAL CHAR, just change parser is okay.Reference link: https://dev.mysql.com/doc/refman/5.7/en/charset-national.html
Check List
Tests
Code changes
Side effects
no
Related changes
no