parser: support to character option to load data statement #7391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Aug 14, 2018
parser/parser.y
Outdated
| @@ -6821,7 +6821,7 @@ RevokeStmt: | |||
| * See https://dev.mysql.com/doc/refman/5.7/en/load-data.html | |||
| *******************************************************************************************/ | |||
| LoadDataStmt: | |||
| "LOAD" "DATA" LocalOpt "INFILE" stringLit "INTO" "TABLE" TableName Fields Lines ColumnNameListOptWithBrackets | |||
| "LOAD" "DATA" LocalOpt "INFILE" stringLit "INTO" "TABLE" TableName Fields Lines ColumnNameListOptWithBrackets CharsetOpt | |||
There was a problem hiding this comment.
CharsetOpt should behind TableName.
added 2 commits
August 14, 2018 19:53
|
/run-all-tests |
|
PTAL @jackysp |
|
/run-all-tests |
jackysp
reviewed
Aug 15, 2018
parser/parser.y
Outdated
| @@ -6821,25 +6821,29 @@ RevokeStmt: | |||
| * See https://dev.mysql.com/doc/refman/5.7/en/load-data.html | |||
| *******************************************************************************************/ | |||
| LoadDataStmt: | |||
| "LOAD" "DATA" LocalOpt "INFILE" stringLit "INTO" "TABLE" TableName Fields Lines ColumnNameListOptWithBrackets | |||
| "LOAD" "DATA" LocalOpt "INFILE" stringLit "INTO" "TABLE" TableName CharsetOpt Fields Lines ColumnNameListOptWithBrackets | |||
jackysp
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #7348 to make some JDBC test cases happy.
What is changed and how it works?
Add a CNF grammar to support
CHARACTER SET <charset_name>at the end ofLOAD DATA.Check List
Tests
Code changes
Side effects
no
Related changes