expression: support builtin function json_contains #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, @mccxj ! |
jackysp
added
contribution
|
pingcap/tipb#99 is merged, you can update the vendor now. @mccxj |
|
@jackysp PTAL |
28 tasks
|
/run-all-tests |
|
LGTM |
coocood
approved these changes
Sep 5, 2018
coocood
added
status/LGT2
|
/run-unit-test |
zz-jason
reviewed
Sep 7, 2018
| return res, isNull, errors.Trace(err) | ||
| } | ||
| var pathExpr json.PathExpression | ||
| if len(b.args) == 3 { |
There was a problem hiding this comment.
It better to write another function signature to handle the scenario that the third argument is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#7299
What is changed and how it works?
add builtin function json_contains according to https://dev.mysql.com/doc/refman/5.7/en/json-search-functions.html#function_json-contains
Check List
Tests
Code changes
add exported method PathExpression#ContainsAnyAsterisk()
Related changes
waiting for pingcap/tipb#99