tidb-server: set TiDBMemQuotaQuery to the value in configuration file #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shenli
reviewed
Sep 17, 2018
| @@ -388,6 +388,9 @@ func setGlobalVars() { | |||
| plan.AllowCartesianProduct = cfg.Performance.CrossJoin | |||
| privileges.SkipWithGrant = cfg.Security.SkipGrantTable | |||
|
|
|||
| variable.SysVars[variable.TIDBMemQuotaQuery].Value = strconv.FormatInt(cfg.MemQuotaQuery, 10) | |||
| variable.SysVars["lower_case_table_names"].Value = strconv.Itoa(cfg.LowerCaseTableNames) | |||
There was a problem hiding this comment.
Just because that they are both set a value to variable.Sysvar.
|
LGTM |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Sep 17, 2018
coocood
pushed a commit
that referenced
this pull request
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
select @@tidb_mem_quota_query;gets the default value of TiDBMemQuotaQuery butnot the value configured in the configuration file.
What is changed and how it works?
Update the
SysVarwhen starting the tidb-server.Check List
Set the
mem-quota-queryin the confiuration file to a value like 100000, thenselect @@tidb_mem_quota_queryfrom the mysql-client.Code changes
Side effects
none
Related changes