Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, planner, executor: implement CREATE TABLE ... SELECT #7787

Closed
wants to merge 9 commits into from
Closed

ddl, planner, executor: implement CREATE TABLE ... SELECT #7787

wants to merge 9 commits into from

Commits on Jan 17, 2019

  1. ddl, planner, executor: implement CREATE TABLE ... SELECT

    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    285c4a9 View commit details
    Browse the repository at this point in the history

  2. fix stylecheck 

    fix pingcap#4754, fix pingcap#3839
    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    66d8fd7 View commit details
    Browse the repository at this point in the history

  3. Address winkyao's comment 

    1. fixed some codestyles
2. added more comments
3. changed the mechnism to insert data(from session server to ddl owner)
4. added support for generated columns
5. added more tests
    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    121f3d8 View commit details
    Browse the repository at this point in the history

  4. address crazycs520's comments

    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2245c38 View commit details
    Browse the repository at this point in the history

  5. address crazycs520's comments #2

    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    5175b34 View commit details
    Browse the repository at this point in the history

  6. address crazycs520's comments #3 

    1. refactor CreateTeableInsertExec to re-use current executors
2. added more test cases
    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2c6d803 View commit details
    Browse the repository at this point in the history

  7. address winkyao's comments

    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    a40e87c View commit details
    Browse the repository at this point in the history

  8. fix merge conflict

    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    bcf5443 View commit details
    Browse the repository at this point in the history

  9. address crazycs520's comments 

    1. fix a bug inserting data into generated columns when creating table
2. fix a 'affected rows' count bug for ddl job
3. refined 'ActionCreateTable' code in delete_range.go
4. fix merge conflict
    @bb7133
    bb7133 committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    ae22d31 View commit details
    Browse the repository at this point in the history