Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, expression: converting to TableDual only when the empty range is not derived from deferred constants (#7579) #7802

Closed
wants to merge 1 commit into from

Conversation

dbjoa
Copy link
Contributor

@dbjoa dbjoa commented Sep 28, 2018

What problem does this PR solve?

fixes #7579

What is changed and how it works?

fix the condition to allow only non-deferred constants

Check List

Tests

  • Unit test

Code changes

  • impl changes

Side effects

  • no

Related changes

  • Need to be included in the release note

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@dbjoa dbjoa changed the title fix: #7579 planner, expression: converting to TableDual only when the empty range is not derived from deferred constants (#7579) Sep 28, 2018
@eurekaka
Copy link
Contributor

/run-build

@eurekaka eurekaka added contribution This PR is from a community contributor. sig/planner SIG: Planner labels Sep 28, 2018
@zz-jason
Copy link
Member

/rebuild

@pingcap pingcap deleted a comment from zz-jason Sep 28, 2018
@iamxy
Copy link
Member

iamxy commented Sep 28, 2018

/rebuild

@dbjoa dbjoa closed this Sep 28, 2018
@dbjoa dbjoa deleted the fix-#7579 branch September 28, 2018 08:09
@dbjoa
Copy link
Contributor Author

dbjoa commented Sep 28, 2018

The script error may be caused by the branch name (including '#'). The PR will be pushed again soon.

@dbjoa
Copy link
Contributor Author

dbjoa commented Sep 28, 2018

The PR has been updated with changing the branch name: #7808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plan cache would be broken if empty range DataSource is converted to TableDual
5 participants