Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv,executor: redesign the latch scheduler (#7711) #7859

Merged
merged 3 commits into from
Oct 12, 2018
Merged

store/tikv,executor: redesign the latch scheduler (#7711) #7859

merged 3 commits into from
Oct 12, 2018

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick #7711 to release-2.1

@disksing @zhangjinpeng1987 @shenli

@tiancaiamao
store/tikv,executor: redesign the latch scheduler (pingcap#7711)
19af19d 
Check maxCommitTS on each key, instead of each slot, so hash collision
will not lead to transaction retry.
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@disksing
Copy link
Contributor

Maybe we should merge it to release branch after we are confident that this feature is stable.

@tiancaiamao
Copy link
Contributor Author

This feature would not be enable by default in release-2.1, so it doesn't matter.
It's cherry picked just in case we need this feature but hard to do that later, as master and release-2.1 will be diverse. @disksing

Randgen test fail, should I run run-all-test on some tidb-test branch ?
@XuHuaiyu

@XuHuaiyu
Copy link
Contributor

@tiancaiamao Plz wait for #7874

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

@disksing @zhangjinpeng1987 @shenli

@disksing
Copy link
Contributor

LGTM.

zz-jason
zz-jason approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Oct 11, 2018
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason merged commit deea24f into pingcap:release-2.1 Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @disksing @XuHuaiyu @zz-jason