*: remove kv.BypassLatch option and enable latch scheduler by default
#7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv.BypassLatch was introduced to handle the fake transaction confliction problem in the old implementation. After redesign of the latch scheduler, it's not needed any more. Enable latch scheduler makes CI to run it, we can fix bugs and make this feature more stable. There is a small performance penalty, less than 5%, users are free to disable it.
|
Can we enable latch and import data to TiDB? |
|
Sure! @ngaut |
|
/run-all-tests |
ngaut
approved these changes
Oct 15, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
kv.BypassLatchwas introduced to handle the fake transaction conflicting problemin the old implementation. After redesign of the latch scheduler, it's not needed any more.
Enable latch scheduler by default makes CI to run it, we can fix bugs and make this feature
more stable.
What is changed and how it works?
Set
Capacityto 2048000 cost about 96M memory.The old value 10240000 cost more than 700M, which I think is too large.
Check List
Tests
Side effects
There is a small performance penalty, less than 5%, users are free to disable it.
@shenli