Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/charset: Add utf8mb4 as alias for utf8 (#7339) #8048

Merged
merged 1 commit into from
Oct 25, 2018
Merged

util/charset: Add utf8mb4 as alias for utf8 (#7339) #8048

merged 1 commit into from
Oct 25, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Oct 25, 2018

Cherry pick from #7339, Fix #8042

zimulala
zimulala reviewed Oct 25, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2018
winoros
winoros approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winkyao
Copy link
Contributor Author

winkyao commented Oct 25, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@winkyao winkyao merged commit 587ff8c into pingcap:release-2.0 Oct 25, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch October 25, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winkyao @zimulala @winoros @morgo