Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix union statements order (#8214) #8238

Merged
merged 3 commits into from
Nov 9, 2018
Merged

planner: fix union statements order (#8214) #8238

merged 3 commits into from
Nov 9, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Nov 8, 2018

cherry-pick #8214

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Nov 8, 2018
@zz-jason
Copy link
Member

zz-jason commented Nov 8, 2018

LGTM

@zz-jason
Copy link
Member

zz-jason commented Nov 8, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Nov 8, 2018
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 8, 2018

PTAL @winoros @eurekaka @lamxTyler

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 9, 2018

PTAL @lamxTyler

zimulala
zimulala approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2018
@zz-jason zz-jason merged commit 8647749 into pingcap:release-2.1 Nov 9, 2018
@XuHuaiyu XuHuaiyu deleted the release-2.1 branch November 14, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @zz-jason @zimulala @mtunique