executor: make sure hashjoin's goroutine exit before Close return
#8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
eurekaka
reviewed
Nov 16, 2018
Closed
|
@eurekaka I only check hashjoin and this new groutine is introduce in those two month. |
|
/run-all-tests |
zz-jason
reviewed
Nov 19, 2018
|
@zz-jason PTAL & /run-all-tests |
zz-jason
reviewed
Nov 19, 2018
executor/join.go
Outdated
| e.fetchInnerDone.Add(1) | ||
| go util.WithRecovery( | ||
| func() { e.fetchInnerRows(ctx, innerResultCh, doneCh) }, | ||
| func(r interface{}) { e.finishFetchInnerRows(innerResultCh) }, |
There was a problem hiding this comment.
Why only finishFetchInnerRows() when the fetchInnerRows() goroutine is paniced?
There was a problem hiding this comment.
not~ it alway call finishFetchInnerRows but with r ==nil
There was a problem hiding this comment.
😂 I was mislead by the r interface{} parameter in the function call.
There was a problem hiding this comment.
can we move the cleaning code into that function, and only do the recover work in this function?
zz-jason
added
status/LGT2
This was referenced Nov 20, 2018
crazycs520
pushed a commit
to crazycs520/tidb
that referenced
this pull request
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #8337
What is changed and how it works?
also wait
fetchInnerRowsgoroutine exit when foundfinishedbe setted.Check List
Tests
Code changes
Side effects
Related changes
This change is