Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor,store/mockstore: add a test to mock get tso fail #8566

Merged
merged 5 commits into from
Dec 4, 2018
Merged

executor,store/mockstore: add a test to mock get tso fail #8566

merged 5 commits into from
Dec 4, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 4, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Make our code more robust

What is changed and how it works?

Add test

Check List

Tests

  • Unit tes
  • No code

Related changes

release-2.0 and release 2.1 may fail on this test

  • Need to cherry-pick to the release branch

@winkyao @crazycs520

This change is Reviewable

@tiancaiamao tiancaiamao mentioned this pull request Dec 4, 2018
Merged
@tiancaiamao tiancaiamao mentioned this pull request Dec 4, 2018
Merged
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

PTAL @crazycs520 @winkyao

crazycs520
crazycs520 reviewed Dec 4, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

@lysu @jackysp

winkyao
winkyao approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit 350a046 into pingcap:master Dec 4, 2018
@tiancaiamao tiancaiamao deleted the mock-get-ts-fail branch December 4, 2018 14:10
@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 4, 2018
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@tiancaiamao @iamzhoug37
executor,store/mockstore: add a test to mock get tso fail (pingcap#8566)
e2d9ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @winkyao @crazycs520