Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvencoder: accelerate kvencoder test executing time #8595

Merged
merged 8 commits into from
Dec 12, 2018
Merged

kvencoder: accelerate kvencoder test executing time #8595

merged 8 commits into from
Dec 12, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 6, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve? 

ok      github.com/pingcap/tidb/util/kvencoder    0.991s    coverage: 78.4% of statements

Before this PR:

ok      github.com/pingcap/tidb/util/kvencoder    1.411s    coverage: 78.4% of statements

This change is Reviewable

crazycs520
crazycs520 reviewed Dec 6, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

zimulala
zimulala approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 11, 2018
@zimulala
Copy link
Contributor

/run-all-tests

@winkyao
Copy link
Contributor Author

winkyao commented Dec 11, 2018

/run-all-tests -tidb-test=pr/691

@winkyao
Copy link
Contributor Author

winkyao commented Dec 11, 2018

/run-common-test -tidb-test=pr/691

@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/run-common-test -tidb-test=pr/691

@zhouqiang-cl
Copy link
Contributor

/run-common-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/rebuild

@winkyao
Copy link
Contributor Author

winkyao commented Dec 12, 2018

/run-all-tests

@winkyao winkyao merged commit 9bd1fb8 into pingcap:master Dec 12, 2018
@winkyao winkyao deleted the accelerate_kvencoder_test branch December 12, 2018 05:04
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@winkyao @iamzhoug37
kvencoder: accelerate kvencoder test executing time (pingcap#8595)
47ea447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@winkyao @zhouqiang-cl @zimulala @crazycs520 @zz-jason @ngaut