Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix abs push down sign bug #8622

Merged
merged 3 commits into from
Dec 10, 2018
Merged

expression: fix abs push down sign bug #8622

merged 3 commits into from
Dec 10, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 7, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve? 

drop table if exists t1;
create table t1(c1 bigint);
insert into t1 (c1) values (-100508511);
select c1 from t1 where abs(c1) = 100508511;

expect:

-got 100508511

but got nothing.

What is changed and how it works?

fix abs's pbCode

Check List

Tests

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu lysu added type/bugfix This PR fixes a bug. component/expression labels Dec 7, 2018
@lysu
Copy link
Contributor Author

lysu commented Dec 7, 2018

/run-all-tests tidb-test=pr/680

XuHuaiyu
XuHuaiyu reviewed Dec 9, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@shenli shenli added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 10, 2018
@shenli
Copy link
Member

shenli commented Dec 10, 2018

LGTM

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 10, 2018
@lysu lysu merged commit 353861f into pingcap:master Dec 10, 2018
@lysu lysu deleted the fix-abs-push-down-sig-bug branch December 10, 2018 02:48
This was referenced Dec 10, 2018
Merged
Merged
zz-jason pushed a commit that referenced this pull request Dec 12, 2018
@lysu @zz-jason
expression: fix abs push down sign bug (#8622) (#8628)
4e4b225
iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018
@lysu @iamzhoug37
expression: fix abs push down sign bug (pingcap#8622)
d71ff3a
ngaut pushed a commit that referenced this pull request Dec 13, 2018
@lysu @ngaut
expression: fix abs push down sign bug (#8622) (#8629)
165a612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@shenli shenli shenli approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @zhouqiang-cl @shenli @XuHuaiyu