plan: build separate required physical property for children #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For logical operator which passs the required physical property down to its children, make a copy for it instead of direct assignment using the original pointer.
|
/run-all-tests |
|
@lamxTyler @XuHuaiyu PTAL |
alivxxx
reviewed
Dec 10, 2018
zz-jason
added
status/LGT2
|
@eurekaka Please cherry pick this change to release-2.1 and release-2.0. |
|
Sure |
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
…#8635) For logical operator which passes the required physical property down to its children, make a copy for it instead of direct assignment using the original pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8634
What is changed and how it works?
RCA is provided here #8634 (comment)
For logical operator which passes the required physical property down to its children, make a copy for it instead of direct assignment using the original pointer.
Check List
Tests
Code changes
Side effects
N/A
Related changes
This change is