Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression,util/encrypt:add support for AES CFB mode #8760

Merged
merged 3 commits into from
Dec 21, 2018
Merged

expression,util/encrypt:add support for AES CFB mode #8760

merged 3 commits into from
Dec 21, 2018

Conversation

kjzz
Copy link
Contributor

@kjzz kjzz commented Dec 20, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

This PR solves part #7490 (add more modes for AES)

What is changed and how it works?

I have included implementation for aes-128-cfb, aes-192-cfb, aes-256-cfb

Check List

  • Unit test

Code changes

  • Has exported AESDecryptWithCFB and AESEncryptWithCFB functions

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shenli shenli added contribution This PR is from a community contributor. component/expression labels Dec 21, 2018
@shenli
Copy link
Member

shenli commented Dec 21, 2018

/run-all-tests

@shenli
Copy link
Member

shenli commented Dec 21, 2018

@kjzz Thanks!

@shenli
Copy link
Member

shenli commented Dec 21, 2018

@jackysp @lysu PTAL

jackysp
jackysp reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Dec 21, 2018

/run-all-tests

@kjzz
Copy link
Contributor Author

kjzz commented Dec 21, 2018

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Dec 21, 2018

/run-unit-test

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-unit-test

lysu
lysu approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 21, 2018
@lysu lysu merged commit b818fb2 into pingcap:master Dec 21, 2018
@lysu
Copy link
Contributor

lysu commented Dec 21, 2018

Thank you for your contribution! @kjzz

yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@kjzz @yu34po
expression,util/encrypt:add support for AES CFB mode (pingcap#8760)
e5033fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjzz @CLAassistant @shenli @jackysp @lysu @zhouqiang-cl