*: make errcheck work again #8795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
jackysp
reviewed
Dec 25, 2018
| @@ -74,7 +75,8 @@ func (o *outerJoinEliminator) isAggColsAllFromOuterTable(outerPlan LogicalPlan, | |||
| } | |||
| for _, col := range aggCols { | |||
| columnName := &ast.ColumnName{Schema: col.DBName, Table: col.TblName, Name: col.ColName} | |||
| if c, _ := outerPlan.Schema().FindColumn(columnName); c == nil { | |||
| if c, err := outerPlan.Schema().FindColumn(columnName); c == nil { | |||
| log.Debug(err) | |||
There was a problem hiding this comment.
I think debug level is too low.
There was a problem hiding this comment.
This error could be ignored @eurekaka
There was a problem hiding this comment.
I prefer log.Warn(err) for err which is not nil.
winoros
reviewed
Dec 25, 2018
| @@ -513,7 +513,9 @@ func (b *executorBuilder) buildShow(v *plannercore.Show) Executor { | |||
| } | |||
| if e.Tp == ast.ShowMasterStatus { | |||
| // show master status need start ts. | |||
| e.ctx.Txn(true) | |||
| if _, err := e.ctx.Txn(true); err != nil { | |||
| b.err = errors.Trace(err) | |||
There was a problem hiding this comment.
The error stack is critical here, I'd rather add more errors.Trace!
lysu
added
status/LGT2
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jan 3, 2019
ngaut
pushed a commit
that referenced
this pull request
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
errcheck is moved to
check_slowin #7240 and it is not used since then.As the title says, this PR recover the check, and now
make checkwill check it by default.What is changed and how it works?
Use errcheck rather than the gometalint (it actually integrate errcheck) tool, because this way we can specify the errcheck_excludes.txt file to control what to be ignored.
Check List
Tests
Side effects
There is a known issue errcheck doesn't support module kisielk/errcheck#155
And it introduce a problem that TiDB must be put in GOPATH
This change is