expression: handle Float32 for builtin function Values() #9215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9215 +/- ##
==========================================
- Coverage 67.22% 67.21% -0.01%
==========================================
Files 371 371
Lines 77050 77052 +2
==========================================
- Hits 51800 51794 -6
- Misses 20625 20631 +6
- Partials 4625 4627 +2
Continue to review full report at Codecov.
|
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Jan 30, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Jan 30, 2019
This was referenced Jan 30, 2019
zz-jason
added a commit
that referenced
this pull request
Jan 30, 2019
zz-jason
added a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Zhang zjsariel@gmail.com
What problem does this PR solve?
fix #8934
What is changed and how it works?
The builtin function
Values()should get a floag32 value from the input Chunk when it's output type ismysql.TypeFloat.Only
ColumnandbuiltinValuesRealSigcallChunk.GetFloat64().Columnhas handled the float32 input value correctly.Check List
Tests
Related changes