ddl: add ddl job error count limit, exceed the limit should cancel the ddl job #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
force-pushed
the
add-ddl-error-limit
branch
from
3b5a097
to
4948905
Compare
|
/run-all-tests |
zimulala
reviewed
Feb 13, 2019
zimulala
reviewed
Feb 13, 2019
crazycs520
force-pushed
the
add-ddl-error-limit
branch
from
9552519
to
3050725
Compare
Codecov Report
@@ Coverage Diff @@
## master #9295 +/- ##
=========================================
- Coverage 67.4% 67.4% -0.01%
=========================================
Files 373 373
Lines 78544 78564 +20
=========================================
+ Hits 52946 52956 +10
- Misses 20838 20847 +9
- Partials 4760 4761 +1
Continue to review full report at Codecov.
|
|
/run-all-tests |
ciscoxll
reviewed
Feb 14, 2019
xiekeyi98
reviewed
Feb 15, 2019
winkyao
reviewed
Feb 15, 2019
zimulala
reviewed
Feb 19, 2019
| } | ||
| } | ||
| return nil | ||
| return true |
There was a problem hiding this comment.
It seems some DDL jobs don't support rollback, and the function returns true. Do we need to wait for other DDL jobs support rollback?
There was a problem hiding this comment.
Mostly ddl rollback is supported.
|
Please address comments. |
|
/run-all-tests |
zimulala
reviewed
Feb 27, 2019
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add DDL job error count limit, if do job error count exceed the limit, and the job is cancelable, then cancel the DDL job to avoid falling into an infinite loop.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes